HL-838 cont. | Allow use of django_language cookie like in TET #2166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirtawast
changed the title
|
Helsinkibenefit-bf-hdlr is deployed to: https://helsinkibenefit-bf-hdlr-2166.test.kuva.hel.ninja 🚀🚀🚀 |
|
Helsinkibenefit-bf-appl is deployed to: https://helsinkibenefit-bf-appl-2166.test.kuva.hel.ninja 🚀🚀🚀 |
|
Helsinkibenefit-bf-bknd is deployed to: https://helsinkibenefit-bf-bknd-2166.test.kuva.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkibenefit-bf-appl-2166.test.kuva.hel.ninja! 😆🎉🎉🎉 |
JanneJuhola
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description ✨
Eauthorization language was still FI even though @mjturt had set
?langparameter. Backend would not save the data however, and after person's authentication, django would drop the ball and fallback to default language when continuing to eauthorization.If this 'accept-language' causes any trouble or side-effects in nextjs then let's see if we can just store 'accept-language' header value to
django_languagecookie.